Improve provider data type#574
Merged
Merged
Conversation
Instead of a String, prefer an Enum with a an explicit list of allowed values.
smortex
marked this pull request as ready for review
January 9, 2026 20:04
bastelfreak
approved these changes
Jan 9, 2026
TheMeier
approved these changes
Jan 10, 2026
ekohl
reviewed
Jan 12, 2026
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
Technically someone could supply their own provider outside of the module and this breaks that support, but I'll admit that is very unlikely. If you weight that off against the possible misconfigurations then it's probably worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a String, prefer an Enum with a an explicit list of allowed
values.